peterxcli commented on issue #23817:
URL: https://github.com/apache/datafusion/issues/23817#issuecomment-5315522232

   > ```rust
   > struct PartitionedFilterExpr {
   >     partitioning: Partitioning, // ex. Partitioning=Hash(column_a, 12)
   >     partition_expr: Arc<dyn PhysicalExpr>, // ex. hash(column_a)
   >     cases: BTreeMap<u64, Arc<dyn PhysicalExpr>>, // map of partition id to 
filter expr 
   > }
   > ```
   
   ```rust
   struct PartitionedFilterExpr {
       partitioning: Partitioning, // ex. Partitioning=Hash(column_a, 12)
       partition_expr: Arc<dyn PhysicalExpr>, // ex. hash(column_a)
       cases: Vec<Option<PhysicalExprRef>>, // map of partition id to filter 
expr 
       fallback: PhysicalExprRef,
   }
   ```
   
   @jayshrivastava I think we could use a vector of optional physical exprs to 
store the sparse partition filters, to reduce the BTree lookup overhead. We 
could also add a new fallback for those edge cases like empty partitions or 
canceled/unknown partitions that we originally handled.
   ref: https://github.com/apache/datafusion/pull/24417
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to