buraksenn commented on PR #24427: URL: https://github.com/apache/datafusion/pull/24427#issuecomment-5324184664
> Thank you for working on this. > > I believe they are intentionally not tracked in the current design: > > https://github.com/apache/datafusion/blob/708ee7ece46e526773bc884ad173fc8cf6a85c2c/datafusion/execution/src/memory_pool/mod.rs#L54-L57 > > > Basically it's only track buffers that scale with the input, and this `LimitedBatchCoalescer` don't because it has length cap `batch_size` from config. > However, this design assumption is controversial and may change. We may need discuss separately (by opening a proposal-epic for changing the memory tracking design, I think) before moving forward with the approach proposed in this PR. Thanks for the review @2010YOUY01. I wanted to tackle #23385 and thought this is a bug in DataFusion as described in the issue. I see that its intentionally left now. @rluvaton, could you clarify whether the intent of #23385 was to change this accounting boundary? If this should instead be treated as a design change, I can move the discussion back to the issue and revise or close this PR based on the outcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
