rluvaton commented on code in PR #23274:
URL: https://github.com/apache/datafusion/pull/23274#discussion_r3806266297
##########
datafusion/expr-common/src/groups_accumulator.rs:
##########
@@ -31,6 +31,12 @@ pub enum EmitTo {
/// For example, if `n=10`, group_index `0, 1, ... 9` are emitted
/// and group indexes `10, 11, 12, ...` become `0, 1, 2, ...`.
First(usize),
+ /// Emit one complete block of groups.
+ ///
+ /// Implementations may handle this the same way as [`EmitTo::First`].
+ /// Block-aware implementations can use it to avoid arbitrary prefix
+ /// shifting when no later update or merge needs contiguous group indexes.
+ FirstBlock(usize),
Review Comment:
if the usize is the numbers of rows, how could implementation be block aware
of unknown size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
