kosiew commented on PR #24423: URL: https://github.com/apache/datafusion/pull/24423#issuecomment-5337998344
@rluvaton > What about convert_to_states? [Added a dedicated per-aggregate `convert_to_state` timer for that path and migration-enabled partial-skip coverage. ](https://github.com/apache/datafusion/pull/24423/commits/7f1af777ea618292b3794d0a6060a9031a31db29) > ..useful to allow for aggregate expressions themself to provide metrics, like array_agg with distinct, there are multiple phases there For aggregate-internal subphases, I’ll keep this PR at the `GroupsAccumulator` call boundary. It already attributes the complete update/merge/state/evaluate operation to each aggregate expression, including `array_agg(DISTINCT ...)`. Letting an aggregate expose its own submetrics needs a separate metrics API plus naming/ownership contract; it would expand the accumulator trait/API beyond this PR’s stated scope. I’ll work on that as follow-up work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
