schenksj commented on PR #4952:
URL:
https://github.com/apache/datafusion-comet/pull/4952#issuecomment-5341165378
Thanks @sunchao — both addressed, head is
`7f8dc65b0d0516d44a31e703756c8a1b88a7bb94`.
**[P2] Unused imports.** Removed all three you named: `ClassLoaders` in
`CometScanContrib.scala`
(its only remaining mention is inside a comment, which is exactly why it
survived my own review),
and `java.util.ServiceLoader` / `scala.util.control.NonFatal` in
`operators.scala`. I left
`scala.jdk.CollectionConverters._` alone in that file — still 16 real uses.
The Lint Java jobs
caught this at the same time; I now run the workflow's exact command
(`scalafix:scalafix -Dscalafix.mode=CHECK -Psemanticdb`) before pushing,
since `spotless:apply`
and `test-compile` both pass happily with a stranded import.
**[P2] Inherited Git configuration.** Correct, and worth being clear that
this was *introduced by my
fix* for your earlier `safe.directory` finding rather than pre-existing:
hardcoding
`GIT_CONFIG_COUNT=1` with `KEY_0` overwrites entry zero of a list the caller
may already be
using. Now appends at the current index:
```bash
GIT_CONFIG_IDX="${GIT_CONFIG_COUNT:-0}"
export "GIT_CONFIG_KEY_${GIT_CONFIG_IDX}=safe.directory"
export "GIT_CONFIG_VALUE_${GIT_CONFIG_IDX}=$ROOT"
export GIT_CONFIG_COUNT=$((GIT_CONFIG_IDX + 1))
```
Verified with your probe: an inherited `protocol.file.allow=never` survives
(`COUNT=2`, both
entries readable via `git config --get`), and the no-inheritance case still
yields `COUNT=1` with
just `safe.directory`. Done here rather than deferred — it is four lines,
and it was a regression
I had just added to a PR that is otherwise ready to merge.
Scalafix CHECK now passes locally on spark-3.5/2.12 with zero proposed
removals.
---
🤖 This reply was drafted with [Claude Code](https://claude.com/claude-code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
