shinzoxD commented on PR #24402: URL: https://github.com/apache/datafusion/pull/24402#issuecomment-5345538096
@kosiew thanks for the review — both comments are addressed in e91860399. - Fallible `CastExpr`s are no longer treated as cheap/safe. Specialization only keeps safe-mode CAST, TRY_CAST, same-type, and widening numeric casts (`CastExpr::check_bigger_cast`). Narrowing casts such as Int32 -> TinyInt skip the fast path (or fall back at eval when the column type is only known from the batch schema), so `CASE WHEN d < 0 THEN CAST(10 AS TINYINT) / CAST(d AS TINYINT) END` over `(-1), (1000), (0)` returns `-10, NULL, NULL` instead of erroring on the excluded 1000. - Added the swapped SQL spelling `0 > d` in `case.slt`, plus the fallible-cast regression there and in the CASE unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
