kazuyukitanimura commented on code in PR #5358:
URL: https://github.com/apache/datafusion-comet/pull/5358#discussion_r3816651171
##########
spark/src/main/spark-3.x/org/apache/comet/shims/CometCollectShim.scala:
##########
@@ -22,7 +22,7 @@ package org.apache.comet.shims
import org.apache.spark.sql.catalyst.expressions.aggregate.{CollectList,
CollectSet}
/**
- * Shim for the `ignoreNulls` flag on `CollectList` / `CollectSet`. Spark 3.4
through 4.1 have no
+ * Shim for the `ignoreNulls` flag on `CollectList` / `CollectSet`. Spark 3.5
through 4.1 have no
Review Comment:
Does it make sense to move `spark-3.x` to `spark-3.5`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
