alamb commented on issue #24410: URL: https://github.com/apache/datafusion/issues/24410#issuecomment-5347817645
> > Is order by old syntax supported already? If not, maybe we could only support old syntax without ordering and let user goes to within group syntax for ordering case > > yes, we already support the old syntax > > > I would prefer to deprecate or remove old syntax since refactor is not costly with agent these day, however not sure how many users would be impacted with this and how they thought about rewriting code to new syntax > > I would prefer that we avoid breaking changes to SQL syntax if it not have a strong reason. In observability systems like our(OpenObserve), dashboards and saved queries are persisted user data and can be difficult to migrate automatically. Such changes could break many dashboards and force downstream systems to add compatibility layers, as [we had to do when upgrading OpenObserve to DataFusion 49](https://github.com/openobserve/openobserve/pull/7649/changes#diff-d9ccf393c53794b0ef2816eef12742c26e23d2788cde27780af7570662aea446R1921-R1978). DataFusion 50 later restored support for the old syntax. Yes, I agree with @haohuaijin (we had the exact same issue with InfluxDB) -- since customers of downstream systems may already be relying on the old syntax, changing the supported SQL is a major burden -- and we don't have direct control over our users -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
