adamreeve commented on code in PR #24505:
URL: https://github.com/apache/datafusion/pull/24505#discussion_r3818075665
##########
benchmarks/compare.py:
##########
@@ -258,7 +258,7 @@ def main() -> None:
"--noise-threshold",
type=float,
default=0.05,
- help="The threshold for statistically insignificant results (+/- %5).",
+ help="The threshold for statistically insignificant results (+/-
5%%).",
Review Comment:
See https://docs.python.org/3/library/argparse.html#help
The help text supports %-formatting so the `%` needs to be escaped.
Without this, running with `--help` gives:
```
ValueError: unsupported format character ')' (0x29) at index 6
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
