vbarua commented on PR #24346: URL: https://github.com/apache/datafusion/pull/24346#issuecomment-5358172823
There is actually a user-facing change in this PR. If DataFusion consumes Substrait plans that set only the deprecated `VirtualTable.values` fields, those fields will be ignored. Elliot's prior changes in https://github.com/apache/datafusion/pull/23672, now released in v55.0.0, make it so DataFusion produces plans using the `VirtualTable.expressions` fields. Any plans produced by DataFusion v55.0.0 onwards should be consumed correctly, which will allow users to update any stored plans they may have. Externally produced plans will also be affected by this change. Users sending plans to DataFusion will need to make sure they are setting `VirtualTable.expressions` in order for DataFusion to see them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
