Dandandan commented on code in PR #24532:
URL: https://github.com/apache/datafusion/pull/24532#discussion_r3824877282
##########
datafusion/expr/src/window_state.rs:
##########
@@ -299,6 +331,7 @@ impl PartitionBatchState {
pub fn extend(&mut self, batch: &RecordBatch) -> Result<()> {
self.record_batch =
Review Comment:
Not this PR per se, but something I notice right now.
How often is this `extend` called? It would probably be better to buffer to
a `Vec` (and delay concatenation) or use
[the](https://docs.rs/arrow/latest/arrow/compute/struct.BatchCoalescer.html)
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
