alamb commented on code in PR #24544: URL: https://github.com/apache/datafusion/pull/24544#discussion_r3825047102
########## datafusion/core/src/physical_planner.rs: ########## @@ -2560,7 +2560,7 @@ type AggregateExprWithOptionalArgs = ( ); /// Create an aggregate expression with a name from a logical expression -#[deprecated(note = "use LoweredAggregateBuilder")] +#[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")] Review Comment: Deprecated in https://github.com/apache/datafusion/pull/21739 (commit 5cf8eef5cf, 2026-05-17), first released in 54.0.0. ########## datafusion/core/src/physical_planner.rs: ########## @@ -2587,7 +2587,7 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter( } /// Create an aggregate expression from a logical expression or an alias -#[deprecated(note = "use LoweredAggregateBuilder")] +#[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")] Review Comment: Deprecated in https://github.com/apache/datafusion/pull/21739 (commit 5cf8eef5cf, 2026-05-17), first released in 54.0.0. ########## datafusion/optimizer/src/push_down_filter.rs: ########## @@ -1343,7 +1343,7 @@ fn rewrite_projection( /// Creates a new LogicalPlan::Filter node. /// /// Deprecated: use [`Filter::try_new`] directly. -#[deprecated] +#[deprecated(since = "55.0.0", note = "Use `Filter::try_new` instead")] Review Comment: Deprecated in https://github.com/apache/datafusion/pull/21668 (commit d318324481, 2026-05-21), first released in 55.0.0. Note this landed just after `branch-54` was cut, so it is 55.0.0 rather than 54.0.0 despite the merge date. This one had a bare `#[deprecated]`, so I also added the `note` the policy asks for, matching what the doc comment above already said. ########## datafusion/functions/src/string/overlay.rs: ########## @@ -16,6 +16,7 @@ // under the License. #[deprecated( + since = "47.0.0", Review Comment: Deprecated in https://github.com/apache/datafusion/pull/15217 (commit 45ed5aa5d0, 2025-03-25), first released in 47.0.0. This is the oldest of the five and is already past the API health policy, so it can be picked up by the next removal sweep. ########## datafusion/physical-plan/src/spill/spill_pool.rs: ########## @@ -476,7 +476,7 @@ pub fn spsc_channel( } /// Alias for [`mpsc_channel`]. -#[deprecated(note = "Use mpsc_channel instead")] +#[deprecated(since = "55.0.0", note = "Use mpsc_channel instead")] Review Comment: Deprecated in https://github.com/apache/datafusion/pull/23522 (commit 12fa0cea76, 2026-07-16), first released in 55.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
