alamb commented on code in PR #12037:
URL: https://github.com/apache/datafusion/pull/12037#discussion_r1719949349
##########
datafusion/core/src/physical_optimizer/mod.rs:
##########
@@ -29,7 +29,6 @@ pub mod join_selection;
pub mod limited_distinct_aggregation;
pub mod optimizer;
pub mod projection_pushdown;
-pub mod pruning;
Review Comment:
there is a
```rust
pub use datafusion_physical_optimizer::*;
```
a few lines down which adds an alias to the `pruning` module in its new home
##########
datafusion/physical-optimizer/src/lib.rs:
##########
@@ -23,3 +23,5 @@ mod optimizer;
pub mod output_requirements;
pub use optimizer::PhysicalOptimizerRule;
+
+pub mod pruning;
Review Comment:
this was just to make the `use` statements less ugly
##########
datafusion/physical-optimizer/src/pruning.rs:
##########
@@ -615,7 +611,8 @@ impl PruningPredicate {
is_always_true(&self.predicate_expr) &&
self.literal_guarantees.is_empty()
}
- pub(crate) fn required_columns(&self) -> &RequiredColumns {
+ /// Return the columns that are required to evaluate the pruning predicate
+ pub fn required_columns(&self) -> &RequiredColumns {
Review Comment:
as it is in a different crate now this function needs to become pub, which I
think is reasonable as it is part of the API
Likewise the change to make `RequiredColumns` pub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
