alamb commented on code in PR #24485:
URL: https://github.com/apache/datafusion/pull/24485#discussion_r3824022190


##########
datafusion/physical-expr-common/src/physical_expr.rs:
##########
@@ -93,12 +93,30 @@ pub trait PhysicalExpr: Any + Send + Sync + Display + Debug 
+ DynEq + DynHash {
             self.nullable(input_schema)?,
         )))
     }
-    /// Evaluate an expression against a RecordBatch after first applying a 
validity array
+    /// Evaluates this expression only for rows where `selection` is `true`.

Review Comment:
   thank you for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to