sunchao commented on code in PR #5400:
URL: https://github.com/apache/datafusion-comet/pull/5400#discussion_r3825950159
##########
native/spark-expr/src/nondetermenistic_funcs/internal/mersenne.rs:
##########
@@ -148,6 +148,8 @@ impl SparkMersenneTwister {
/// Port of `BitsStreamGenerator.nextInt(int n)`. The caller always passes
a
/// strictly positive `n`, matching Spark's `random.nextInt(i + 1)`.
+ // `isolate_lowest_one` requires Rust 1.97, newer than Comet's Rust 1.88
MSRV.
+ #[allow(clippy::manual_isolate_lowest_one)]
Review Comment:
[P2] Keep this allowance compatible with pre-1.98 Clippy
On Clippy 1.97.1 (and 1.91), this newly introduced lint name is itself
unknown, so the documented `cargo clippy --all-targets --workspace -- -D
warnings` workflow fails with `unknown lint: clippy::manual_isolate_lowest_one`
(`-D unknown-lints` is implied by `-D warnings`). I reproduced this with the
unmodified Mersenne module from both commits: the exact base passes and this
head fails at this attribute. Ordinary Rust compilation still succeeds. Since
these toolchains are newer than the declared Rust 1.88 minimum, please make the
allowance backward-compatible, for example `#[allow(unknown_lints,
clippy::manual_isolate_lowest_one)]`; that form passes both Clippy 1.97.1 and
the installed 1.99 nightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
