fornwall commented on code in PR #24534:
URL: https://github.com/apache/datafusion/pull/24534#discussion_r3826613470
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -538,8 +538,9 @@ pub fn create_physical_expr(
let dt = schema.field(0).data_type().clone();
Ok(Arc::new(ScalarSubqueryExpr::new(
dt,
- // A scalar subquery may return no rows and evaluate
to NULL.
- true,
+ // Defer to the logical nullability rule, which
accounts
+ // for subqueries guaranteed to produce at least one
row.
Review Comment:
Agreed, deleted the comment in e2654b05f26fd190bc2cffa26158b5f5f2ab150c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
