adriangb commented on issue #18856: URL: https://github.com/apache/datafusion/issues/18856#issuecomment-5372955887
> The only benefit is that the `HashJoinExec` can determine during planning that it's filter was pushed down, rather than in the `execute()` call. Since this isn't a hard blocker, so I'm okay with not adding the new state for now. Can't it determine that now? `HashJoinExec::handle_child_pushdown_result` is called at planning time by the filter pushdown operator with `Yes` (was pushed down) or `No` (was not pushed down) for each filter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
