Dandandan commented on PR #24456: URL: https://github.com/apache/datafusion/pull/24456#issuecomment-5373701443
> I haven't had time to look into the details of the code, but since this is still a draft I'd like to mention [DpHyp](https://www.researchgate.net/publication/47862092_Dynamic_Programming_Strikes_Back) for the join ordering problem. I think the current approach is more close to `DPsub` but of course I am open to try `DpHyp` and see differences. I think one shortcoming of the current approach is not supporting non-inner/semi joins, so solving that with some approach would be great and probably improve performance somewhat more! On my machine with the join ordering, DataFusion beats DuckDB on TPC-H at least (didn't check TPC-DS). It would make a nice blog post if that's a robust result... I also agree with @alamb if we have a nice API that allows to register a different algorithm, one could just swap the default (although my goal would be to have a great default that works >90% of the time). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
