kosiew commented on code in PR #24415: URL: https://github.com/apache/datafusion/pull/24415#discussion_r3835932054
########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -2858,6 +2858,44 @@ NULL 1970-01-04T00:00:00 789 ghi 1970-01-04 NULL 789 qwe NULL NULL NULL NULL NULL 1970-01-04T00:00:00 0 qwerty NULL NULL NULL NULL NULL NULL 100000 abcdefg +# Regression test: projection pushdown through SortMergeJoinExec must not reuse a +# JoinFilter after its input columns have been projected away. +statement ok +set datafusion.optimizer.repartition_joins = true; + +query TT Review Comment: Could we also add a `LEFT` or `FULL` join case with an unmatched row and a join filter that references projected-away columns? The current regression test covers the inner join case well. An outer join case would also exercise the remapping when null-extended rows are involved. This is just a suggestion and does not need to block this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
