andygrove commented on code in PR #835:
URL: https://github.com/apache/datafusion-comet/pull/835#discussion_r1720286290
##########
native/Cargo.toml:
##########
@@ -44,6 +44,7 @@ datafusion = { default-features = false, git =
"https://github.com/apache/datafu
datafusion-functions = { git = "https://github.com/apache/datafusion.git";, rev
= "41.0.0-rc1", features = ["crypto_expressions"] }
datafusion-functions-nested = { git =
"https://github.com/apache/datafusion.git";, rev = "41.0.0-rc1",
default-features = false }
datafusion-expr = { git = "https://github.com/apache/datafusion.git";, rev =
"41.0.0-rc1", default-features = false }
+datafusion-execution = { git = "https://github.com/apache/datafusion.git";, rev
= "41.0.0-rc1", default-features = false }
Review Comment:
We use `use datafusion::execution::TaskContext`. I guess we were just
pulling this in transitively before via the `datafusion` crate rather than
being explicit.
We may want to avoid bringing in the core `datafusion` crate and just depend
directly on the crates that we need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
