peterxcli opened a new pull request, #5443: URL: https://github.com/apache/datafusion-comet/pull/5443
## Which issue does this PR close? Closes #5208. ## Rationale for this change Native `make_date` uses chrono date construction, whose supported year range is narrower than Spark `DateType`. This causes Comet to reject Spark-valid dates such as `300000-06-15` and `300000-02-29`. ## What changes are included in this PR? - Reuse the existing proleptic-Gregorian `ymd_to_epoch_day` helper and narrow its result to Arrow `Date32`. - Remove the resolved chrono-range compatibility note. - Add Rust unit coverage and native SQL parity coverage with ANSI mode both disabled and enabled. ## How are these changes tested? - `cargo fmt --manifest-path native/Cargo.toml --all -- --check` - `cargo test --manifest-path native/Cargo.toml -p datafusion-comet-spark-expr datetime_funcs::make_date::tests` (5 passed) - `make core` - `./mvnw test -Dtest=none -Dsuites='org.apache.comet.CometSqlFileTestSuite make_date' -Dscalastyle.skip=true` (2 passed) - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
