viirya commented on code in PR #802:
URL: https://github.com/apache/datafusion-comet/pull/802#discussion_r1720415516
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -210,8 +210,29 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
expr match {
case agg: AggregateExpression =>
agg.aggregateFunction match {
- case _: Min | _: Max | _: Count =>
+ case _: Count =>
Some(agg)
+ case min: Min =>
+ if (minMaxDataTypeSupported(min.dataType)) {
+ Some(agg)
+ } else {
+ withInfo(windowExpr, "Unsupported datatype", expr)
Review Comment:
Can we put the data type in the error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
