adriangb commented on code in PR #24601: URL: https://github.com/apache/datafusion/pull/24601#discussion_r3844991452
########## datafusion/physical-plan/src/execution_plan.rs: ########## @@ -1122,7 +1122,12 @@ where /// /// This traverses both the execution plan and the children of each expression root /// reported by [`ExecutionPlan::apply_expressions`]. -pub(crate) fn plan_contains_expression_id( +/// +/// Producers of dynamic filters use this to find out whether anything downstream +/// holds the filter they pushed, since a node that replies +/// [`PushedDown::No`](crate::filter_pushdown::PushedDown::No) may still retain it +/// for statistics pruning. +pub fn plan_contains_expression_id( Review Comment: I don't love making this public just for another workspace member. Unfortunately no way around it (other than adding a `test` feature or something). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
