jayzhan211 commented on code in PR #11989:
URL: https://github.com/apache/datafusion/pull/11989#discussion_r1720493069
##########
datafusion/functions-aggregate-common/src/aggregate.rs:
##########
@@ -171,6 +171,9 @@ pub trait AggregateExpr: Send + Sync + Debug +
PartialEq<dyn Any> {
fn get_minmax_desc(&self) -> Option<(Field, bool)> {
None
}
+
+ /// Get function's name, for example `count(x)` returns `count`
+ fn func_name(&self) -> &str;
Review Comment:
This is to identify function (i.e. count), there is `name()` already, but it
includes arguments, which is not I want.
Alternative way is introduce `nullable()` for AggregateUDF, so we don't need
name checking. Maybe I should done it before this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
