Omega359 commented on code in PR #24583:
URL: https://github.com/apache/datafusion/pull/24583#discussion_r3847374592
##########
benchmarks/sql_benchmarks/h2o/benchmarks/window/q14.benchmark:
##########
@@ -0,0 +1,26 @@
+subgroup window
+
+name Q14
+group h2o
+
+echo Loading ${H2O_BENCH_SIZE:-small} window ${H2O_FILE_TYPE:-csv} h2o data
+
+load
sql_benchmarks/h2o/init/load_window_${H2O_BENCH_SIZE:-small}_${H2O_FILE_TYPE:-csv}.sql
+
+assert I
+SELECT COUNT(*) > 0 FROM x
+----
+true
+
+run
+-- Window Top-N partition cardinality sweep (id3 % N gives N distinct
partitions).
+-- These exercise PartitionedTopKExec across cardinalities to validate it stays
Review Comment:
@alamb Currently this PR mirrors the setup for the rust (h2o.rs) version,
whatever the fix is I think either is outside of the benchmarks or applies to
both types (till the rust-based benchmarks are removed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
