Rich-T-kid commented on issue #24111: URL: https://github.com/apache/datafusion/issues/24111#issuecomment-5401316069
> > [@alamb](https://github.com/alamb), [#24227](https://github.com/apache/datafusion/pull/24227) does exactly this. The diff (+943, -19) makes the PR look much larger than it actually is: roughly 400-500 LOC is tests covering a variety of edge cases (mixed column encoding within a single file, mixed encoding across multiple files, reading non-VLD types, verifying the correct schema propagates between operators, SLT tests, etc.), and another large chunk is just propagating the flag throughout the codebase. > > Thanks -- I am sorry I just don't have time to review all the PRs anymore. I do think Dictionary support is important, and so am trying to help with the project but I don't want to lead you on and imply I have bandwidth to help drive / review this project in any meaningful way at the moment understandable, your advice is still very appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
