github-actions[bot] commented on PR #24561: URL: https://github.com/apache/datafusion/pull/24561#issuecomment-5401551428
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.0.0 (current) Built [ 33.602s] (current) Parsing datafusion-expr v55.0.0 (current) Parsed [ 0.081s] (current) Building datafusion-expr v55.0.0 (baseline) Built [ 29.030s] (baseline) Parsing datafusion-expr v55.0.0 (baseline) Parsed [ 0.084s] (baseline) Checking datafusion-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 2.078s] 223 checks: 220 pass, 3 fail, 0 warn, 31 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: ScalarUDF::display_name, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/7f66ea7cb840e6752ccdedef94ed84cf1cacaa5b/datafusion/expr/src/udf.rs:193 ScalarUDF::is_nullable, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/7f66ea7cb840e6752ccdedef94ed84cf1cacaa5b/datafusion/expr/src/udf.rs:259 WindowAggState::is_input_unchanged, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/7f66ea7cb840e6752ccdedef94ed84cf1cacaa5b/datafusion/expr/src/window_state.rs:147 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_missing.ron Failed in: field n_rows_received of struct PartitionBatchState, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/7f66ea7cb840e6752ccdedef94ed84cf1cacaa5b/datafusion/expr/src/window_state.rs:304 field n_rows_received of struct WindowAggState, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/7f66ea7cb840e6752ccdedef94ed84cf1cacaa5b/datafusion/expr/src/window_state.rs:55 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron Failed in: method display_name of trait ScalarUDFImpl, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/7f66ea7cb840e6752ccdedef94ed84cf1cacaa5b/datafusion/expr/src/udf.rs:564 method is_nullable of trait ScalarUDFImpl, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/7f66ea7cb840e6752ccdedef94ed84cf1cacaa5b/datafusion/expr/src/udf.rs:705 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 66.166s] datafusion-expr Building datafusion-functions v55.0.0 (current) Built [ 30.807s] (current) Parsing datafusion-functions v55.0.0 (current) Parsed [ 0.089s] (current) Building datafusion-functions v55.0.0 (baseline) Built [ 31.014s] (baseline) Parsing datafusion-functions v55.0.0 (baseline) Parsed [ 0.091s] (baseline) Checking datafusion-functions v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.535s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 64.099s] datafusion-functions Building datafusion-functions-nested v55.0.0 (current) Built [ 36.634s] (current) Parsing datafusion-functions-nested v55.0.0 (current) Parsed [ 0.041s] (current) Building datafusion-functions-nested v55.0.0 (baseline) Built [ 36.084s] (baseline) Parsing datafusion-functions-nested v55.0.0 (baseline) Parsed [ 0.043s] (baseline) Checking datafusion-functions-nested v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.272s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 74.326s] datafusion-functions-nested ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
