alamb commented on code in PR #24640:
URL: https://github.com/apache/datafusion/pull/24640#discussion_r3847675641
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -358,6 +358,17 @@ pub enum AggregateMode {
/// This reduces shuffling traffic in a distributed setting. See
///
<https://github.com/datafusion-contrib/datafusion-distributed/issues/360>
/// for details.
+ ///
+ /// # Best-Effort Reduction
Review Comment:
@njsmith and @gabotechs does this match your understanding of what
PartialReduce is supposed to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
