jayzhan211 commented on code in PR #11989:
URL: https://github.com/apache/datafusion/pull/11989#discussion_r1720745280
##########
datafusion/physical-expr-functions-aggregate/src/aggregate.rs:
##########
@@ -435,6 +459,10 @@ impl AggregateExpr for AggregateFunctionExpr {
.is_descending()
.and_then(|flag| self.field().ok().map(|f| (f, flag)))
}
+
+ fn default_value(&self, data_type: &DataType) -> Result<ScalarValue> {
Review Comment:
I need to add 4 places for a new function, might be room to improve 🤔
Maybe we don't need `AggregateExpr` since there is only one implement at
all. I think trait is useful if there are at least 2 implementation shares
similar function. Similar idea from #11810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
