geoffreyclaude commented on code in PR #24687: URL: https://github.com/apache/datafusion/pull/24687#discussion_r3862946379
########## datafusion/physical-expr/src/expressions/in_list/fixed_size_binary_filter.rs: ########## Review Comment: I also checked this locally using the current HEAD of #24662 as the baseline. Stacking this PR on top still reduces the LLVM IR for `fixed_size_binary_filter` from 3,514 to 1,563 lines (-56%). Across the whole crate that is 647,380 → 645,429 (-0.30%), while the linked benchmark binary is 7.5 KB smaller (-0.09%). So yes, much smaller than before #24662, but the savings are still real, and the code is still clearer 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
