alamb commented on PR #11456: URL: https://github.com/apache/datafusion/pull/11456#issuecomment-2294825368
> I was hoping to merge that first before taking a stab at the required extensions in datafusion/sql/src/planner.rs that would allow us to run those queries. Once we have those I will be able to add some SLT tests and fix any newly uncovered bugs in both files. Implementing in phases makes sense to me and is consistent with what we have done in other places However, I still think we should add basic .slt test coverage (even if they simply error our with "unsupported subquery") is to document, with code, what the expected behavior is if someone runs this kind of query. I think a runtime "not yet implemented" error is fine, but going into infinite loops or internal errors is probably less good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
