thorfour commented on code in PR #24565:
URL: https://github.com/apache/datafusion/pull/24565#discussion_r3866596359


##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -1083,6 +1083,8 @@ fn extract_window_frame_target_type(col_type: &DataType) 
-> Result<DataType> {
         Ok(DataType::Interval(IntervalUnit::MonthDayNano))
     } else if let DataType::Dictionary(_, value_type) = col_type {
         extract_window_frame_target_type(value_type)
+    } else if let DataType::RunEndEncoded(_, value_type) = col_type {

Review Comment:
   Some options I could think of:
   
   1. We do nothing and wait for Arrow to implement this arithmetic.
   2. We special case the windowing function to check if REE and perform the 
necessary arithmetic itself.
   3. We add a step in planning to check if RANGE is being used on REE column 
and return the error in planning.
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to