jayzhan211 commented on code in PR #12043:
URL: https://github.com/apache/datafusion/pull/12043#discussion_r1720762466
##########
datafusion/functions-window/src/row_number.rs:
##########
@@ -31,8 +31,8 @@ use datafusion_expr::{Expr, PartitionEvaluator, Signature,
Volatility, WindowUDF
/// Create a [`WindowFunction`](Expr::WindowFunction) expression for
/// `row_number` user-defined window function.
-pub fn row_number(args: Vec<Expr>) -> Expr {
- Expr::WindowFunction(WindowFunction::new(row_number_udwf(), args))
+pub fn row_number() -> Expr {
Review Comment:
Given there is signature Any(0) but the test in round_trip still works.
I guess we should add `data_types_with_window_udf` somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
