sunchao commented on PR #24680: URL: https://github.com/apache/datafusion/pull/24680#issuecomment-5432227172
Thanks @comphead, confirmed and fixed in [e79e91236](https://github.com/apache/datafusion/pull/24680/commits/e79e91236e662d3084c7656eae78751027d1633d). The guard now looks through the selected field's container value types, covering the reported List families, Map, and Dictionary cases while retaining only the selected field path. The existing regression now covers these containers and deeper nesting. I also added protection for matching-type narrowing, chained field access, and existing container-to-Struct conversions, which must keep their current casting path. The Parquet regression covers `List<Utf8>` to `List<Decimal128(10, -1)>` under an entirely null Struct with filter pushdown both enabled and disabled. Validation passed: 42 adapter tests, 249 Parquet datasource tests, 227 Parquet integration tests, 8 doctests (5 existing ignores), and 21 SQL logic files. Formatting, Clippy across all targets/features with warnings denied, and the full repository lint suite also passed. This addresses the [container-decimal finding](https://github.com/apache/datafusion/pull/24680#pullrequestreview-5035191811). I updated the PR description with the container example and the validation results for this revision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
