asolimando opened a new pull request, #24716: URL: https://github.com/apache/datafusion/pull/24716
## Which issue does this PR close? - Closes #23671. ## Rationale for this change `JoinSelection`'s internal statistics helpers each took separate `config: &ConfigOptions` and `registry: Option<&StatisticsRegistry>` parameters. Any new session-scoped CBO input to these rules (e.g. #21120) would require touching every helper's signature. ## What changes are included in this PR? Replace the `config`/`registry` parameter pair on the internal statistics helpers with a single `context: &dyn PhysicalOptimizerContext`, reading `context.config_options()` and `context.statistics_registry()` internally. This is a pure internal signature change: all affected functions are private or `pub(crate)`, with no cross-crate callers. Behavior is unchanged. ## Are these changes tested? No new tests; this is a non-functional refactor covered by existing tests (`cargo test -p datafusion-physical-optimizer`, the `physical_optimizer::join_selection` integration tests, and `statistics_registry.slt`). ## Are there any user-facing changes? No. ---- Disclaimer: I used AI to assist in the code generation, I have manually reviewed the output and it matches my intention and understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
