Kev1n8 commented on PR #12044:
URL: https://github.com/apache/datafusion/pull/12044#issuecomment-2294908528

   The following is my latest bench report of `SUBSTR`:
   ```
   
   SHORTER THAN 12/substr_string_view [size=1024, strlen=12]
                           time:   [29.675 µs 29.964 µs 30.402 µs]
                           change: [-0.1382% +0.9754% +2.5969%] (p = 0.20 > 
0.05)
                           No change in performance detected.
   Found 1 outliers among 10 measurements (10.00%)
     1 (10.00%) high severe
   SHORTER THAN 12/substr_string [size=1024, strlen=12]
                           time:   [59.403 µs 59.823 µs 60.292 µs]
                           change: [+0.2182% +0.9242% +1.7185%] (p = 0.04 < 
0.05)
                           Change within noise threshold.
   SHORTER THAN 12/substr_large_string [size=1024, strlen=12]
                           time:   [41.462 µs 41.775 µs 42.064 µs]
                           change: [-0.7169% +0.3030% +1.2513%] (p = 0.57 > 
0.05)
                           No change in performance detected.
   
   LONGER THAN 12/substr_string_view [size=1024, count=64, strlen=128]
                           time:   [68.409 µs 68.896 µs 69.437 µs]
                           change: [-22.017% -10.028% +1.0113%] (p = 0.23 > 
0.05)
                           No change in performance detected.
   LONGER THAN 12/substr_string [size=1024, count=64, strlen=128]
                           time:   [101.98 µs 102.20 µs 102.55 µs]
                           change: [-0.1908% +0.0183% +0.3687%] (p = 0.92 > 
0.05)
                           No change in performance detected.
   Found 1 outliers among 10 measurements (10.00%)
     1 (10.00%) high severe
   LONGER THAN 12/substr_large_string [size=1024, count=64, strlen=128]
                           time:   [101.90 µs 102.32 µs 102.80 µs]
                           change: [+0.1753% +0.5640% +1.0536%] (p = 0.01 < 
0.05)
                           Change within noise threshold.
   
   SRC_LEN > 12, SUB_LEN < 12/substr_string_view [size=1024, count=6, 
strlen=128]
                           time:   [15.031 µs 15.180 µs 15.331 µs]
   SRC_LEN > 12, SUB_LEN < 12/substr_string [size=1024, count=6, strlen=128]
                           time:   [33.738 µs 34.057 µs 34.370 µs]
   SRC_LEN > 12, SUB_LEN < 12/substr_large_string [size=1024, count=6, 
strlen=128]
                           time:   [33.509 µs 34.122 µs 35.075 µs]
   Found 2 outliers among 10 measurements (20.00%)
     1 (10.00%) high mild
     1 (10.00%) high severe
   
   SHORTER THAN 12/substr_string_view [size=4096, strlen=12]
                           time:   [120.22 µs 121.43 µs 122.70 µs]
                           change: [+1.3982% +2.3499% +3.4501%] (p = 0.00 < 
0.05)
                           Performance has regressed.
   SHORTER THAN 12/substr_string [size=4096, strlen=12]
                           time:   [237.06 µs 251.39 µs 268.81 µs]
                           change: [+1.6838% +7.2415% +14.130%] (p = 0.04 < 
0.05)
                           Performance has regressed.
   SHORTER THAN 12/substr_large_string [size=4096, strlen=12]
                           time:   [163.27 µs 164.24 µs 165.40 µs]
                           change: [-0.2464% +0.3706% +1.0851%] (p = 0.34 > 
0.05)
                           No change in performance detected.
   Found 2 outliers among 10 measurements (20.00%)
     2 (20.00%) high mild
   
   LONGER THAN 12/substr_string_view [size=4096, count=64, strlen=128]
                           time:   [275.69 µs 277.81 µs 280.16 µs]
                           change: [+0.9658% +1.8029% +2.6242%] (p = 0.00 < 
0.05)
                           Change within noise threshold.
   Found 1 outliers among 10 measurements (10.00%)
     1 (10.00%) high mild
   LONGER THAN 12/substr_string [size=4096, count=64, strlen=128]
                           time:   [416.84 µs 419.95 µs 423.71 µs]
                           change: [-1.6174% -0.0917% +1.2731%] (p = 0.91 > 
0.05)
                           No change in performance detected.
   Found 1 outliers among 10 measurements (10.00%)
     1 (10.00%) high mild
   LONGER THAN 12/substr_large_string [size=4096, count=64, strlen=128]
                           time:   [419.60 µs 421.94 µs 424.48 µs]
                           change: [+1.5505% +2.0977% +2.7392%] (p = 0.00 < 
0.05)
                           Performance has regressed.
   Found 1 outliers among 10 measurements (10.00%)
     1 (10.00%) high mild
   
   SRC_LEN > 12, SUB_LEN < 12/substr_string_view [size=4096, count=6, 
strlen=128]
                           time:   [59.933 µs 60.122 µs 60.355 µs]
   Found 1 outliers among 10 measurements (10.00%)
     1 (10.00%) high mild
   SRC_LEN > 12, SUB_LEN < 12/substr_string [size=4096, count=6, strlen=128]
                           time:   [133.30 µs 134.66 µs 135.97 µs]
   SRC_LEN > 12, SUB_LEN < 12/substr_large_string [size=4096, count=6, 
strlen=128]
                           time:   [131.37 µs 141.42 µs 158.42 µs]
   Found 1 outliers among 10 measurements (10.00%)
     1 (10.00%) high severe
   
   substr_index_array_array_1000
                           time:   [64.130 µs 68.632 µs 73.376 µs]
                           change: [-16.971% -10.021% -2.4160%] (p = 0.01 < 
0.05)
                           Performance has improved.
   Found 14 outliers among 100 measurements (14.00%)
     4 (4.00%) high mild
     10 (10.00%) high severe
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to