alamb commented on code in PR #24718:
URL: https://github.com/apache/datafusion/pull/24718#discussion_r3871545008
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_sorting/sort_pushdown.rs:
##########
@@ -1045,7 +1045,7 @@ fn build_join_column_index(plan: &HashJoinExec) ->
Vec<ColumnIndex> {
.chain(map_fields(plan.right().schema(), JoinSide::Right))
.collect::<Vec<_>>()
}
- JoinType::RightSemi | JoinType::RightAnti => {
+ JoinType::RightSemi | JoinType::RightAnti | JoinType::RightMark => {
map_fields(plan.right().schema(), JoinSide::Right)
}
_ => unreachable!("unexpected join type: {}", plan.join_type()),
Review Comment:
To make this more defensive, it would be great to make this unreachable into
an internal error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
