github-actions[bot] commented on PR #24728: URL: https://github.com/apache/datafusion/pull/24728#issuecomment-5441190845
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.0.0 (current) Built [ 31.639s] (current) Parsing datafusion-expr v55.0.0 (current) Parsed [ 0.076s] (current) Building datafusion-expr v55.0.0 (baseline) Built [ 30.736s] (baseline) Parsing datafusion-expr v55.0.0 (baseline) Parsed [ 0.077s] (baseline) Checking datafusion-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.385s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_expr::udaf_default_schema_name now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udaf.rs:965 --- failure function_requires_different_generic_type_params: function now requires a different number of generic type parameters --- Description: A function now requires a different number of generic type parameters than it used to. Uses of this function that supplied the previous number of generic types (e.g. via turbofish syntax) will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_requires_different_generic_type_params.ron Failed in: function udaf_default_window_function_schema_name (1 -> 0 generic types) in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udaf.rs:1072 function udaf_default_schema_name (1 -> 0 generic types) in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udaf.rs:965 function udaf_default_display_name (1 -> 0 generic types) in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udaf.rs:1137 function udaf_default_human_display (1 -> 0 generic types) in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udaf.rs:1026 function udaf_default_window_function_display_name (1 -> 0 generic types) in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udaf.rs:1185 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 65.186s] datafusion-expr ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
