andygrove commented on PR #4957: URL: https://github.com/apache/datafusion-comet/pull/4957#issuecomment-5441682678
> **Note on this review:** this was generated by an LLM (Claude Code) at my request while I worked through a review backlog. I have not verified the individual findings myself. Please treat everything below as suggestions to evaluate rather than as authoritative review feedback, and push back on anything that is wrong or already handled. This one cannot merge as-is and I think it needs a human decision rather than another dependabot rebase. **Two `object_store` versions end up in the tree** The lockfile shows `object_store 0.13.2` and `object_store 0.14.1` coexisting: Comet's direct dependency moves to 0.14.1 while DataFusion and the other transitive consumers stay on 0.13.2. That is not just wasted binary size. `ObjectStore` trait objects created against one version cannot be handed to code compiled against the other, which is exactly what Comet does when it registers a store into DataFusion's `ObjectStoreRegistry`. Type errors from that are almost certainly what the six native build failures are. So this bump is blocked on DataFusion moving to `object_store` 0.14. Is there an upstream issue tracking that? Linking it here would make it clear the PR should stay open but parked rather than be repeatedly rebased. **CI status** Six checks are failing, all of them native builds: Linux and macOS "Build Native Library", `ubuntu-latest/rust-test`, and the Spark 3.5 / 4.1 / Iceberg native build jobs. Everything that does not compile Rust passes. That is consistent with the version-split diagnosis above. **Suggestion** Rather than leaving this open and red, it might be worth closing it with a comment pointing at the DataFusion upgrade that unblocks it, and letting dependabot reopen once the constraint is gone. A long-lived red PR at the top of the queue costs reviewer attention every time someone scans the list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
