sunchao commented on PR #5489: URL: https://github.com/apache/datafusion-comet/pull/5489#issuecomment-5442351822
Updated in [093db4c78](https://github.com/apache/datafusion-comet/commit/093db4c784fa538b150e4ee7aff6975662b70058). Addressed the mixed-log retry bug: explicit permanent HTTP/artifact/build errors now stop the attempt even when an earlier line reports a connection reset. The new regressions fail on the previous helper and verify one invocation, the original exit status, and no backoff; a long-summary case prevents a fixed-tail workaround. The helper remains restricted to dependency acquisition, and Maven goals/Spark compilation and tests are not rerun. All 26 download/cache/Delta checks pass locally, including Maven 3.9.6 against the loopback HTTP server. These are local results for the new commit; the previous [hosted preflight](https://github.com/apache/datafusion-comet/actions/runs/33037810141/job/98404353014) ran the original 24 checks in about 36 seconds (29.105 seconds for download/cache tests and 4.942 seconds for Delta checks). For the other questions: - Maven 3.9.6 defaults to Resolver native HTTP, so Wagon retry settings do not replace the `aether.connector.http.retryHandler` settings here. The dependency-only SBT updates directly address the [Spark download 502](https://github.com/apache/datafusion-comet/actions/runs/33018849422/job/98352428975); they do not retry compilation or tests. - The [builder](https://github.com/apache/datafusion-comet/actions/runs/33037810141/job/98404750419) saved and the [catalyst shard](https://github.com/apache/datafusion-comet/actions/runs/33037810141/job/98411586504) restored the same full `Linux-X64-spark-sbt-v1-4.1.3-c4e071c238e732a97e0117554d9b25b46a1fdef8270b281b8c3eba49a4064eb8` key. Spark POMs remain in the key because SBT consumes them. - Every current job calls `setup-maven` once. Repeating the same constant options would not alter their meaning; skipping already-present options could retain an incompatible caller policy. - The quoted-space `MAVEN_OPTS` example fails identically in the unchanged `mvnw` launcher, so it is not a cache-probe regression. The probe must honor supported home overrides to select the same distribution directory as the wrapper; `MAVEN_USER_HOME` paths containing spaces remain tested. I have kept the related download changes together: SBT pre-resolution addresses the observed dependency failure, and Delta logging retains the failing command's diagnostics. No build/test retry scope was added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
