dwsmith1983 commented on PR #5365: URL: https://github.com/apache/datafusion-comet/pull/5365#issuecomment-5443012067
Thanks for taking a look, and thanks Chao for the corrections, no arguments from me there. This did prompt a few improvements though. The default feature choice came out of earlier review discussion, but you're right it belonged in the description. It's there now along with the measured cost, about 82 KB on a roughly 380 MB debug dylib, and it's unreachable without the contrib jar plus the config. The DV decoder concern was fair, so there's now a malformed-input matrix in the native tests: truncation at every byte offset, CRC and magic corruption, length and cardinality lies, and bit-flip sweeps. Everything errors cleanly, no panics. On version skew, Chao was right that linkage errors used to propagate. The claim hook now contains LinkageError as a logged decline, so a mismatched contrib jar falls back to Spark instead of breaking planning. There's a test that fakes a NoSuchMethodError contrib to pin that. Also cleaned up the description itself, a few garbled words and stale pre-convergence module names, which is probably what made the benchmark section look cut off. CI numbers are in there too: the contrib jobs are path gated and the suite runs 4 to 5 minutes per Spark profile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
