zvonimir-dd commented on PR #2436:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2436#issuecomment-5443263961
Filed the follow-ups that surfaced during this review, so they don't get
lost:
- #2460 — `DIV`'s right operand is parsed at precedence 0 in the MySQL and
Spark dialects. Spotted by
@LucaCappelletti94 in his review above; his patch and test are in the
issue.
- #2461 — `Ampersand` (23) sits above `PgOther` (21) in the default table,
so `a -> b & c` groups as
`((a -> b) & c)` in PostgreSQL but `(a -> (b & c))` in MySQL/Generic.
One-line change, suite green.
- #2462 — MySQL's `->` / `->>` bind more tightly than arithmetic, which
`PgOther` cannot express
since PostgreSQL places the arrow *below* `+`. Needs a design decision.
All three are out of scope for this PR — I'd rather land this one first and
take them separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
