kosiew commented on code in PR #24664: URL: https://github.com/apache/datafusion/pull/24664#discussion_r3879468483
########## datafusion/physical-plan/src/display.rs: ########## Review Comment: Nice fix. As a follow-up, it might be worth considering terminal display-cell width here, for example with `unicode-width`, rather than counting Unicode scalar values. This fixes the UTF-8 boundary panic, but wide emoji and CJK characters can still occupy more than one terminal column, which may cause the rendered tree to exceed its box or misalign connectors. This looks like pre-existing behavior to me, so I would not consider it blocking for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
