theirix commented on code in PR #24703:
URL: https://github.com/apache/datafusion/pull/24703#discussion_r3883341589
##########
datafusion/functions/src/math/floor.rs:
##########
@@ -123,10 +133,7 @@ impl ScalarUDFImpl for FloorFunc {
}
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
- match &arg_types[0] {
- DataType::Null => Ok(DataType::Float64),
- other => Ok(other.clone()),
- }
+ Ok(decimal_floor_ceil_return_type(&arg_types[0]))
Review Comment:
Thank you for the review! I've fixed edge cases for the preimage.
Regarding the change - I agree, even if it's a different decimal point type
in the decimal domain, it is still a different type. Updated the user-facing
changes PR section. If this approach is fine, I'll also add a change to the
upgrading notes doc for 56.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
