github-actions[bot] commented on PR #24766: URL: https://github.com/apache/datafusion/pull/24766#issuecomment-5460231454
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-ffi v55.0.0 (current) Built [ 55.303s] (current) Parsing datafusion-ffi v55.0.0 (current) Parsed [ 0.062s] (current) Building datafusion-ffi v55.0.0 (baseline) Built [ 55.068s] (baseline) Parsing datafusion-ffi v55.0.0 (baseline) Parsed [ 0.061s] (baseline) Checking datafusion-ffi v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.262s] 223 checks: 221 pass, 1 fail, 1 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field ForeignLibraryModule.create_exec_with_range_partitioning in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:126 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: ForeignLibraryModule.create_table_with_statistics moved from position 18 to 19, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:128 ForeignLibraryModule.create_physical_optimizer_rule moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:131 ForeignLibraryModule.create_context_aware_optimizer_rule moved from position 20 to 21, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:133 ForeignLibraryModule.create_query_planner moved from position 21 to 22, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:137 ForeignLibraryModule.version moved from position 22 to 23, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:143 ForeignLibraryModule.create_first_value_udaf moved from position 23 to 24, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:146 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 113.258s] datafusion-ffi Building datafusion-physical-expr v55.0.0 (current) Built [ 29.959s] (current) Parsing datafusion-physical-expr v55.0.0 (current) Parsed [ 0.049s] (current) Building datafusion-physical-expr v55.0.0 (baseline) Built [ 29.991s] (baseline) Parsing datafusion-physical-expr v55.0.0 (baseline) Parsed [ 0.050s] (baseline) Checking datafusion-physical-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.332s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 61.509s] datafusion-physical-expr Building datafusion-physical-plan v55.0.0 (current) Built [ 40.188s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.156s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 39.722s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.153s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.668s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 82.256s] datafusion-physical-plan Building datafusion-proto-models v55.0.0 (current) Built [ 26.110s] (current) Parsing datafusion-proto-models v55.0.0 (current) Parsed [ 0.133s] (current) Building datafusion-proto-models v55.0.0 (baseline) Built [ 25.783s] (baseline) Parsing datafusion-proto-models v55.0.0 (baseline) Parsed [ 0.132s] (baseline) Checking datafusion-proto-models v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.749s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field PhysicalRangePartitioning.sample_point in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2371 field PhysicalRangePartitioning.partition_count in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2374 field PhysicalRangePartitioning.sample_point in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2371 field PhysicalRangePartitioning.partition_count in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2374 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 55.523s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
