sunchao commented on code in PR #4950:
URL: https://github.com/apache/datafusion-comet/pull/4950#discussion_r3889724370
##########
.github/workflows/ci.yml:
##########
@@ -117,6 +126,7 @@ jobs:
spark_3_5: ${{ steps.compute.outputs.spark_3_5 }}
spark_4_0: ${{ steps.compute.outputs.spark_4_0 }}
spark_4_1: ${{ steps.compute.outputs.spark_4_1 }}
+ spark_4_2: ${{ steps.compute.outputs.spark_4_2 }}
Review Comment:
[P2] Set `spark_4_2` during manual dispatch
This output is never set for `workflow_dispatch`: the manual `for key` list
still stops at `spark_4_1` and exits before `compute-changes.py` runs. The new
job requires `needs.changes.outputs.spark_4_2 == true`, so every manual run
silently skips it despite the nearby promise that manual dispatch forces every
output to true. Please add `spark_4_2` to that list. The current labeled PR run
uses the pull-request path and is unaffected; this is specific to the manual
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
