cj-zhukov commented on code in PR #24633:
URL: https://github.com/apache/datafusion/pull/24633#discussion_r3890115730
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -2628,17 +2628,16 @@ impl DataFrame {
/// # Ok(())
/// # }
/// ```
- pub fn from_columns(columns: Vec<(&str, ArrayRef)>) -> Result<Self> {
- let fields = columns
- .iter()
- .map(|(name, array)| Field::new(*name, array.data_type().clone(),
true))
- .collect::<Vec<_>>();
-
- let arrays = columns
+ pub fn from_columns<'a, I>(columns: I) -> Result<Self>
Review Comment:
@kosiew Thanks for the clarification. I understand the remaining
compatibility concern now.
My goal is to allow `from_columns` to accept arrays and other `IntoIterator`
inputs while keeping the existing `Vec` usage working. I’d prefer to keep this
behavior under `from_columns` rather than introduce a second method.
I agree that this is a breaking change under the API-health policy. I’ll
update the PR accordingly, including adding the `api-change` label, updating
the description, and providing upgrade guidance where appropriate.
Once the changes are ready, I’ll let you know and ask for another review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
