NoahKusaba opened a new pull request, #2398:
URL: https://github.com/apache/datafusion-ballista/pull/2398
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
Fairly harmless de-dupe I found while working on a different feature.
`SchedulerServer::new` and `new_with_task_launcher` differ only in how they
build the `SchedulerState`. The ~30 lines after that were duplicated
verbatim,
including two `#[cfg(feature = "rest-api")]` blocks — so a divergence could
compile under default features and break the non-`rest-api` build.
# What changes are included in this PR?
Moves the shared tail into a private `from_state`; both constructors delegate
to it. Net -23 lines, moved block byte-identical.
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
