gabotechs commented on code in PR #24673: URL: https://github.com/apache/datafusion/pull/24673#discussion_r3892060906
########## datafusion/physical-expr-common/src/metrics/mod.rs: ########## Review Comment: Yeah, probably. I bet this was not done before because some built-in metrics like `OutputRows` do not have a `name` field. There are a couple more inconsistencies with the metrics API, so probably worth revisiting at some point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
