alamb commented on code in PR #2465:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2465#discussion_r3894069764
##########
src/parser/mod.rs:
##########
@@ -72,46 +72,25 @@ macro_rules! parser_err {
mod alter;
mod merge;
-#[cfg(feature = "std")]
-/// Implementation [`RecursionCounter`] if std is available
mod recursion {
- use std::cell::Cell;
- use std::rc::Rc;
+ use alloc::rc::Rc;
+ use core::cell::Cell;
use super::ParserError;
- /// Tracks remaining recursion depth. This value is decremented on
Review Comment:
why remove all these comments?
##########
.github/workflows/rust.yml:
##########
@@ -81,6 +81,7 @@ jobs:
uses: ./.github/actions/setup-builder
with:
targets: 'thumbv6m-none-eabi'
+ - run: cargo test --release --no-default-features --test no_std_recursion
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
